[PATCH] D137982: Reland [pgo] Avoid introducing relocations by using private alias
Paul Kirth via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 24 15:02:24 PST 2023
paulkirth updated this revision to Diff 491928.
paulkirth added a comment.
Don't create an alias when type metadata is present. We need a more thoughtful
solution for the ThinLTO + CFI case, since we would need to move any generated
aliases into the main module w/ the jump tables.
That will require more complex changes to some combination of CFI and PGO, and
is sufficiently complex to warrant its own patch. In the meantime we can still
benefit from generating the alias in most cases.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137982/new/
https://reviews.llvm.org/D137982
Files:
compiler-rt/test/profile/instrprof-discarded-comdat.cpp
llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp
llvm/test/Transforms/PGOProfile/comdat.ll
llvm/test/Transforms/PGOProfile/profdata_priv_alias.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D137982.491928.patch
Type: text/x-patch
Size: 11475 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230124/b59920a0/attachment.bin>
More information about the llvm-commits
mailing list