[PATCH] D142216: [MC] Store number of implicit operands in MCInstrDesc. NFC.

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 24 14:16:47 PST 2023


foad added a comment.

In D142216#4078359 <https://reviews.llvm.org/D142216#4078359>, @gulfem wrote:

> BOLT seems like using the removed `getImplicitUses` method(). That's why we started seeing the following failure:
>
>   [3786/4445](41) Building CXX object tools/bolt/lib/Passes/CMakeFiles/LLVMBOLTPasses.dir/LivenessAnalysis.cpp.o
>   In file included from /opt/s/w/ir/x/w/llvm-llvm-project/bolt/lib/Passes/LivenessAnalysis.cpp:9:
>   /opt/s/w/ir/x/w/llvm-llvm-project/bolt/include/bolt/Passes/LivenessAnalysis.h:145:30: error: no member named 'getImplicitUses' in 'llvm::MCInstrDesc'
>         for (auto I = InstInfo.getImplicitUses(),
>                       ~~~~~~~~ ^
>   /opt/s/w/ir/x/w/llvm-llvm-project/bolt/include/bolt/Passes/LivenessAnalysis.h:146:30: error: no member named 'getImplicitUses' in 'llvm::MCInstrDesc'
>                   E = InstInfo.getImplicitUses() + InstInfo.getNumImplicitUses();
>                       ~~~~~~~~ ^
>   /opt/s/w/ir/x/w/llvm-llvm-project/bolt/include/bolt/Passes/LivenessAnalysis.h:146:59: error: no member named 'getNumImplicitUses' in 'llvm::MCInstrDesc'
>                   E = InstInfo.getImplicitUses() + InstInfo.getNumImplicitUses();
>
> https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8791052753995739793/+/u/clang/build/stdout

Sorry. Can you please try converting this code to the `for (I : implicit_uses())` style? If not I will do it tomorrow.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142216/new/

https://reviews.llvm.org/D142216



More information about the llvm-commits mailing list