[llvm] 78a5f0a - [TargetParser] Remove an EXPECT that is never executed

Paul Robinson via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 24 12:27:40 PST 2023


Author: Paul Robinson
Date: 2023-01-24T12:27:32-08:00
New Revision: 78a5f0a78ae11028e5e8337eb4039d7b88c8985e

URL: https://github.com/llvm/llvm-project/commit/78a5f0a78ae11028e5e8337eb4039d7b88c8985e
DIFF: https://github.com/llvm/llvm-project/commit/78a5f0a78ae11028e5e8337eb4039d7b88c8985e.diff

LOG: [TargetParser] Remove an EXPECT that is never executed

Found by the Rotten Green Tests project.

Added: 
    

Modified: 
    llvm/unittests/TargetParser/TargetParserTest.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/unittests/TargetParser/TargetParserTest.cpp b/llvm/unittests/TargetParser/TargetParserTest.cpp
index 2429ab45d4fb..51f6b6468079 100644
--- a/llvm/unittests/TargetParser/TargetParserTest.cpp
+++ b/llvm/unittests/TargetParser/TargetParserTest.cpp
@@ -1657,9 +1657,6 @@ TEST(TargetParserTest, AArch64ArchPartialOrder) {
 
   for (const auto *A : AArch64::ArchInfos) {
     EXPECT_EQ(*A, *A);
-    if (!(*A == *A)) {
-      EXPECT_NE(*A, *A);
-    }
     // Comparison with invalid is always false
     EXPECT_FALSE(A->implies(AArch64::INVALID));
     EXPECT_FALSE(AArch64::INVALID.implies(*A));


        


More information about the llvm-commits mailing list