[PATCH] D140250: Define NULL in its own header

Ian Anderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 24 12:13:38 PST 2023


iana added a comment.

In D140250#4077974 <https://reviews.llvm.org/D140250#4077974>, @iana wrote:

> In D140250#4077956 <https://reviews.llvm.org/D140250#4077956>, @aaron.ballman wrote:
>
>> In D140250#4077826 <https://reviews.llvm.org/D140250#4077826>, @iana wrote:
>>
>>> In D140250#4076851 <https://reviews.llvm.org/D140250#4076851>, @aaron.ballman wrote:
>>>
>>>> I'd expect there to be a test under `clang/test/Headers/` showing that this new header works as expected.
>>>
>>> It's covered pretty well by stddefneeds.cpp already. I can add a new one if you want, but it'd pretty much be a copy/paste
>>
>> I was thinking of one similar to that but includes the new header and *not* stddef.h to demonstrate that this works entirely standalone. WDYT?
>
> Yeah ok sure

Added, let me know if it's missing anything please!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140250/new/

https://reviews.llvm.org/D140250



More information about the llvm-commits mailing list