[PATCH] D142443: [ORC] Drop Comdat when discarding IR symbol

[Jonas Hahnfeld via Phabricator via llvm-commits]

Hahnfeld added a comment.

In D142443#4077610 <https://reviews.llvm.org/D142443#4077610>, @sunho wrote:

> What happens when we actually have duplicate comdat any definitions? IIRC I've seen that in msvcrt.lib.

I'm not sure I understand your question. I think this is partially what https://reviews.llvm.org/D138264 is about? De-duplicating Comdat symbols on Linux doesn't seem to work as of now, hence the `weak` definition in `weak-comdat.ll` (but I'm not really into this Comdat business, not sure if a non-weak definition should work there).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142443/new/

https://reviews.llvm.org/D142443