[PATCH] D142473: [UTC] Add --version argument

Jannik Silvanus via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 24 08:38:23 PST 2023


jsilvanus added a comment.

I would not be so worried about the complexity of having to maintain multiple version formats -- we can think of the version flag  as setting defaults for command-line options that alter the test format.
We already have such options (e.g. mentioned `--function-signature`), so this is not new in principle, it just provides a convenient means to set these.

On the implementation side, I'm wondering whether it would be better to avoid directly checking `version` in the implementation, and instead derive some options (similar to args, or even args itself?) from the version and then only use that?
For example, if some old version introduced several changes (to avoid "version churn"), it is later probably easier to later remove support for one of them is there is a dedicated internal flag for each change.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142473/new/

https://reviews.llvm.org/D142473



More information about the llvm-commits mailing list