[PATCH] D140514: [VPlan] Use VPDominatorTree in VPlanVerifier .

[Ayal Zaks via Phabricator via llvm-commits]

Ayal accepted this revision.
Ayal added a comment.
This revision is now accepted and ready to land.

Ship it!



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:9165
 
+#ifndef NDEBUG
   assert(VPlanVerifier::verifyPlanIsValid(*Plan) && "VPlan is invalid");
----------------
nit: can be done independent of this patch.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlanVerifier.cpp:212
           continue;
 
         // If the user is in the same block, check it comes after R in the
----------------
nit: can introduce a method that takes two recipes (along with their numberings) and says if one dominates the other, whether they belong to the same VPBB's or not. Analogous to DominatorTree interfaces.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140514/new/

https://reviews.llvm.org/D140514