[PATCH] D142305: [ADT] llvm::bit_cast - use __builtin_bit_cast if available

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 24 08:06:48 PST 2023


dblaikie added a comment.

> If the compiler supports __builtin_bit_cast we should try to use it instead of std::memcpy (and avoid including the cstring header).

Why? Maintaining non-portable code has some cost, if we can get similar/sufficient/the same performance without special casing, that seems better. Do we not get adequate performance with `std::memcpy`? Is the header especially expensive to include?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142305/new/

https://reviews.llvm.org/D142305



More information about the llvm-commits mailing list