[PATCH] D142446: [MC] Disable copying and moving of MCInstrDescs the C++20 way

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 24 06:16:47 PST 2023


foad added inline comments.


================
Comment at: llvm/include/llvm/MC/MCInstrDesc.h:224
+  // find other information elsewhere in the same table.
+  [[no_unique_address]] NonCopyableNonMovable NCNM{};
 
----------------
Ugh, I had not realized that in C++17 this attribute is unrecognized and does nothing, so the NCNM member increases the size of this struct from 48 bytes to 56 bytes (on 64-bit hosts). Maybe I should give up and leave the FIXME in place until we have adopted C++20.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142446/new/

https://reviews.llvm.org/D142446



More information about the llvm-commits mailing list