[PATCH] D142031: [AArch64][SME2] Add intrinsics to move multi-vectors to/from ZA.

[David Sherwood via Phabricator via llvm-commits]

david-arm added a comment.

Thanks for addressing my many review comments! It's almost perfect. :)



================
Comment at: llvm/test/CodeGen/AArch64/sme2-intrinsics-insert-mova.ll:536
+; CHECK-NEXT:    // kill: def $z0 killed $z0 killed $z0_z1_z2_z3 def $z0_z1_z2_z3
+; CHECK-NEXT:    mov za.d[w8, 0, vgx4], { z0.d - z3.d }
+; CHECK-NEXT:    ret
----------------
For the vector to array writes I think we can test non-zero slices here too similar to `@za_read_vg1x4_f64`?

i.e.

  %slice.7 = add i32 %slice, 7
  call void @llvm.aarch64.sme.write.vg1x4.nxv2i64(i32 %slice.7, <vscale x 2 x i64> %za1, <vscale x 2 x i64> %za2, <vscale x 2 x i64> %za3, <vscale x 2 x i64> %za4)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142031/new/

https://reviews.llvm.org/D142031