[PATCH] D142231: [AMDGPU][AsmParser] Forbid optional SMRD offsets on GFX6/GFX7.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D142231#4076375 <https://reviews.llvm.org/D142231#4076375>, @dp wrote:

> The patch itself looks fine, but it breaks backward compatibility with existing code.
> I think if you make offset mandatory for GFX6 and GFX7, the same should be done for other GPUs. But IMO preserving compatibility with existing code is more important.
> BTW, have you noticed that SP3 does not allow 32-bit offsets with SMRD? LLVM assembler accepts these, but I do not know if HW can handle it.

I think that worked for CI only


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142231/new/

https://reviews.llvm.org/D142231