[PATCH] D142429: [InstCombine] Use `analyzeKnownBitsFromAndXorOr` in `SimplifyDemandedUseBits` for and/xor/or

Tue Jan 24 02:56:29 PST 2023

goldstein.w.n added a comment.

In D142429#4076067 <https://reviews.llvm.org/D142429#4076067>, @nikic wrote:

> This is going to unnecessarily recompute known bits we already have. Please go with the helpers instead. Doing a recursive computeKnownBits() call for an operand we didn't check yet is fine, but we shouldn't recompute the known bits we already have.

Done in V2. Made the AndXorOr helper public in previous patch (`D142427`) so now just goes through `analyzeKnownBitsFromAndXorOr`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142429/new/

https://reviews.llvm.org/D142429