[PATCH] D142444: [IPSCCP][FuncSpec] Fix compiler crash 60191.

[Alexandros Lamprineas via Phabricator via llvm-commits]

labrinea added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/FunctionSpecialization.cpp:627
+    if (CS->arg_size() != CalledFunction->arg_size())
+      continue;
 
----------------
nikic wrote:
> Is it okay if the arguments have different types? (If no, then you'll want to compare getFunctionType()).
Good point, I'll look into it.


================
Comment at: llvm/test/Transforms/FunctionSpecialization/compiler-crash-60191.ll:1
+; RUN: opt -S -mtriple=amdgcn-amd-amdhsa --passes="default<O3>" < %s
+
----------------
nikic wrote:
> Can you avoid the triple in the test?
> 
> Also, is it possible to reduce the test such that it only requires running ipsccp, and not the whole opt pipeline?
I couldn't get the compiler crash without the triple, or if I further reduced the test. I'll try harder. If I change the pass to "ipsccp<func-spec>" or just "ipsccp" (func-spec is implied by default) the test will still crash.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142444/new/

https://reviews.llvm.org/D142444