[PATCH] D142441: [Docs] Add best practices for regression tests

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

In D142441#4076303 <https://reviews.llvm.org/D142441#4076303>, @barannikov88 wrote:

> Thanks, this is really helpful. One question:
>
>> Avoid unnamed instructions/blocks (such as ``%0`` or ``1:``).
> Why so? (It would be nice to clarify this in the doc.)

Added a note. Basically, if you remove an unnamed instruction, you need to renumber all following instructions. Also, generated check lines don't use wildcards for basic block names, so while check lines don't care about var names, they care about block names, which are less stable if you use unnamed blocks in the input.

I have a handy script that I use whenever I need to touch a test with unnamed instructions: https://gist.github.com/nikic/145581a29ce951c31e2650ad322359e4


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142441/new/

https://reviews.llvm.org/D142441