[PATCH] D141994: [IndVars] Expand icmp in preheader rather than in loop

[Aleksandr Popov via Phabricator via llvm-commits]

aleksandr.popov added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/IndVarSimplify.cpp:1363
   BranchInst *BI = cast<BranchInst>(ExitingBB->getTerminator());
   Rewriter.setInsertPoint(BI);
   auto *LHSV = Rewriter.expandCodeFor(LIP.LHS);
----------------
nikic wrote:
> I still think that we should be adjusting this insertion point as well...
Got it, thanks! 
Moved expander's insertion point to the preheader


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141994/new/

https://reviews.llvm.org/D141994