[PATCH] D142214: [MC] Do not copy MCInstrDescs. NFC.

[Sam McCall via Phabricator via llvm-commits]

sammccall added a comment.

In D142214#4076245 <https://reviews.llvm.org/D142214#4076245>, @foad wrote:

> In D142214#4076194 <https://reviews.llvm.org/D142214#4076194>, @sammccall wrote:
>
>> TL;DR: this doesn't work in C++20, maybe revert?
>>
>>> I'm surprised the aggregate init works given the deleted copy ctor here, but if it works, it works I guess *shrug*
>>
>> The aggregate init works up to C++17, but not in C++20.
>> (The rules change from "no user-provided, inherited, or explicit constructors" to "no user-declared or inherited constructors").
>>
>> I think the current status of building LLVM in C++20 mode is "theoretically supported, but no stable buildbot yet". It's being worked on <https://lab.llvm.org/staging/#/builders/237>.
>>
>> Since C++20 compatibility is something we'll need to do in the medium-term, and incompatible constructs make building a good bot harder in the short-term, I'd reluctantly suggest reverting this.
>>
>> (Eliminating the aggregate init or finding an alternative technique to break copy/move also seem fine, starting with a revert would still be nice if it's not trivial)
>
> Interesting. Is there any easy way I can test building in C++20 mode on my own machine?

Looks like you should set -DCMAKE_CXX_STANDARD=20 (this lets me reproduce this class of error locally, with clang++-12 as host compiler).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142214/new/

https://reviews.llvm.org/D142214