[PATCH] D142438: [Docs] Mention GitHub commit comments as a possible post-commit review venue

[Nikita Popov via Phabricator via llvm-commits]

nikic created this revision.
Herald added a subscriber: StephenFan.
Herald added a project: All.
nikic requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Mention GitHub commit comments as a possible venue where post-commit review can take place. I believe that commit comments are already being extensively used for this purpose, so this is documenting existing practice.

I've dropped the mention of the development mailing list, because I don't think that's a typical review channel -- it's an escalation route towards the RFC process, but I'd consider that beyond the purview of simple post-commit review.


https://reviews.llvm.org/D142438

Files:
  llvm/docs/CodeReview.rst


Index: llvm/docs/CodeReview.rst
===================================================================
--- llvm/docs/CodeReview.rst
+++ llvm/docs/CodeReview.rst
@@ -80,8 +80,8 @@
 
 Pre-commit code reviews are conducted on our web-based code-review tool (see
 :doc:`Phabricator`). Post-commit reviews can be done on Phabricator, by email
-on the relevant project's commit mailing list, on the project's development
-list, or on the bug tracker.
+on the relevant project's commit mailing list, using commit comments on GitHub,
+or on the bug tracker.
 
 When Is an RFC Required?
 ------------------------


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D142438.491651.patch
Type: text/x-patch
Size: 601 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230124/c646cb2a/attachment.bin>