[PATCH] D142429: [InstCombine] Use `computeKnownBits` in `SimplifyDemandedUseBits` for and/xor/or
Nikita Popov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 24 00:47:53 PST 2023
nikic requested changes to this revision.
nikic added a comment.
This revision now requires changes to proceed.
This is going to unnecessarily recompute known bits we already have. Please go with the helpers instead. Doing a recursive computeKnownBits() call for an operand we didn't check yet is fine, but we shouldn't recompute the known bits we already have.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142429/new/
https://reviews.llvm.org/D142429
More information about the llvm-commits
mailing list