[PATCH] D138757: [zero-call-used-regs] Mark only non-debug instruction's register as used

Shivam Gupta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 23 23:39:49 PST 2023


xgupta added inline comments.


================
Comment at: llvm/lib/CodeGen/PrologEpilogInserter.cpp:1243
           MCRegister Reg = MO.getReg();
           if (AllocatableSet[Reg] && !MO.isImplicit() &&
               (MO.isDef() || MO.isUse()))
----------------
MatzeB wrote:
> Haven't followed this patch series. But skipping implicit operands seems odd at a first glance. They can read and write registers perfectly fine...
not sure, maybe @nickdesaulniers or @void can comment on skipping implicit operands.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138757/new/

https://reviews.llvm.org/D138757



More information about the llvm-commits mailing list