[PATCH] D136044: [compiler-rt][builtins] Skip building (b)float16 support on i386-freebsd

Phoebe Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 23 19:48:09 PST 2023


pengfei added a comment.





================
Comment at: compiler-rt/lib/builtins/CMakeLists.txt:804
           if(NOT COMPILER_RT_HAS_${arch}_VFP_DP)
             list(REMOVE_ITEM ${arch}_SOURCES ${arm_Thumb1_VFPv2_DP_SOURCES})
           endif()
----------------
Should move the removal of `GENERIC_BF_SOURCES` in this loop like this (Just wild guess. I'm neither familiar with compiler-rt nor cmake)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136044/new/

https://reviews.llvm.org/D136044



More information about the llvm-commits mailing list