[PATCH] D139970: [llvm][CallBrPrepare] use SSAUpdater to use intrinsic value

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 23 16:31:39 PST 2023


nickdesaulniers added a comment.

In D139970#4067188 <https://reviews.llvm.org/D139970#4067188>, @efriedma wrote:

> Instead of having InsertIntrinsicCalls construct a map of SSAUpdaters, then have UpdateSSA iterate through it, can you just perform all the SSA updates involving a given SSAUpdater immediately after constructing it?  The separation seems to add complexity without any benefit.

Yeah, that was a nice cleanup. PTAL.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139970/new/

https://reviews.llvm.org/D139970



More information about the llvm-commits mailing list