[PATCH] D142408: [SanitizerBinaryMetadata] Declare callbacks extern weak

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka accepted this revision.
vitalybuka added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Transforms/Utils/ModuleUtils.cpp:181
+  auto Fn = M.getOrInsertFunction(InitName, FnTy);
+  if (Weak && !AlreadyDeclared) {
+    // We cannot set extern_weak if this function has already been declared or
----------------
maybe we want skip only if it's defined?
What is the reason to respect declaration?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142408/new/

https://reviews.llvm.org/D142408