[PATCH] D142397: [BOLT] Emit a warning about invalid entries in function-order list

Maksim Panchenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 23 15:02:01 PST 2023


maksfb added inline comments.


================
Comment at: bolt/lib/Passes/ReorderFunctions.cpp:386-387
+      if (InvalidEntries)
+        errs() << "BOLT-WARNING: ReorderFunctions: can't find functions for "
+               << InvalidEntries << " entries in -function-order list.\n";
     }
----------------
nit: keep naming ("Reorder functions" vs "ReorderFunctions") consistent (you can also use `this->getName()`). Drop the trailing period.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142397/new/

https://reviews.llvm.org/D142397



More information about the llvm-commits mailing list