[PATCH] D142404: [docs] Prefer setting LLVM_HOST_TRIPLE instead of LLVM_DEFAULT_TARGET_TRIPLE and LLVM_TARGET_ARCH

Chris Bieneman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 23 14:40:20 PST 2023


beanz added a comment.

In D142404#4074985 <https://reviews.llvm.org/D142404#4074985>, @mstorsjo wrote:

> No, here I disagree. `LLVM_HOST_TRIPLE` is documented as `Host on which LLVM binaries will run`, not as the host where I'm currently compiling it. We can easily infer the details of the OS where we're doing the build, but usually much less so for the cross target, where the cross compiled LLVM will run.

Ooof... That is the most terribly named variable ever. You are right. I kinda hate the idea of documenting this because that variable name is unnecessarily confusing. In fact, the line directly above the line you changed uses the word `host` to mean something completely different.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142404/new/

https://reviews.llvm.org/D142404



More information about the llvm-commits mailing list