[PATCH] D142382: [LV] Test case to show the problem with forced vec and rt-checks. NFC.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 23 14:01:31 PST 2023


fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks! I still think it would be slightly preferable to not rely on debug output in the test and run it unconditionally, but don't have strong feelings about it.



================
Comment at: llvm/test/Transforms/LoopVectorize/memcheck_threashold_vec_forced.ll:53
+
+for.cond.cleanup.loopexit:
+  ret void
----------------
nit: IMO it would be slightly more readable to put this at the end of the function and rename it to `exit`. (same below)


================
Comment at: llvm/test/Transforms/LoopVectorize/memcheck_threashold_vec_forced.ll:109
+!11 = !{!"llvm.loop.vectorize.enable", i1 true}
+;; NOTE: These prefixes are unused and the list is autogenerated. Do not add tests below this line:
+; CHECK-DEBUG: {{.*}}
----------------
Looks like the custom check lines cause this warning by the script. Perhaps remove the lines?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142382/new/

https://reviews.llvm.org/D142382



More information about the llvm-commits mailing list