[PATCH] D141553: [bazel] Enable layering_check for llvm and clang

Mon Jan 23 13:25:54 PST 2023

MaskRay added a comment.

In D141553#4074491 <https://reviews.llvm.org/D141553#4074491>, @shahms wrote:

> https://github.com/kythe/kythe/pull/5511
>
> Is the relevant PR with the workaround for this (which is, indeed, "just" patching the LLVM BUILD files to remove the feature), alongside my workaround for the empty globs.

I don't know how to build kythe and I cannot find any occurrence of `llvm_external_zlib`...
https://github.com/kythe/kythe/pull/5511 looks reasonable. `features = ["layering_check"],` in the upstream helps catch problems.
If a downstream project patches something and runs into failures (please give detailed instructions; bazel is an unsupported build system anyway), removing `layering_check` is reasonable.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141553/new/

https://reviews.llvm.org/D141553