[PATCH] D142216: [MC] Store number of implicit operands in MCInstrDesc. NFC.

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 23 12:42:11 PST 2023


foad added inline comments.


================
Comment at: llvm/utils/TableGen/InstrInfoEmitter.cpp:117
 
 static void PrintDefList(const std::vector<Record*> &Uses,
                          unsigned Num, raw_ostream &OS) {
----------------
barannikov88 wrote:
> This is confusing.
> The name suggests it prints defs, the parameter name is `Uses`, but it really prints both.
> 
Yes, but it goes away in D142218 :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142216/new/

https://reviews.llvm.org/D142216



More information about the llvm-commits mailing list