[PATCH] D142326: [clang][RISCV][test] Add test cases for empty structs and the FP calling conventions

[Alex Bradbury via Phabricator via llvm-commits]

asb added inline comments.


================
Comment at: clang/test/CodeGen/RISCV/abi-empty-structs.c:101
+
+struct s5 { struct empty e[1]; float f; };
+
----------------
luismarques wrote:
> Should we also test a case with an array size 0 like `ct s { struct empty e[0]; float f; };`? I think that's a GNU extension and I don't expect the result to be different but...
> 
Good idea and thanks for the review. As it stands, this patch has the bare minimum set of tests I'd be happy to land the ABI test fix. I'll try and do another pass to add in more tomorrow.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142326/new/

https://reviews.llvm.org/D142326