[PATCH] D142292: [SCEV] Introduce `SCEVSelectExpr`

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:4395
+  if (const SCEV *S = findExistingSCEVInCache(Kind, Ops))
+    return S;
+
----------------
nikic wrote:
> This check can currently be omitted, because we already check for existing scev below. This early check is only needed if there are expensive recursive folds which we try to bypass.
Here and elsewhere: i have no clue what this is supposed to mean,
and i don't feel like guessing. Is this is a statement, a passing-by remark,
or a change request? If you are requesting changes, please do so explicitly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142292/new/

https://reviews.llvm.org/D142292