[PATCH] D142102: [RISCV] Combine FP_TO_INT to vfwcvt/fvncvt

Luke Lau via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 23 10:39:57 PST 2023


luke marked an inline comment as done.
luke added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVVLPatterns.td:883
+
+multiclass VPatNConvertFP2IVL_W<SDNode vop, string instruction_name> {
+  // Reuse the same list of types used in the widening nodes, but just swap the
----------------
craig.topper wrote:
> I'd prefer we didn't rename things in this patch. It makes the diff bigger and makes the view in phabricator more confusing. If you want to rename, do it as a separate pre-patch.
Of course, left them out for now. The intention was to bring it in line with the pseudo and spec convention of suffixing instructions that access wider register groups with `w`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142102/new/

https://reviews.llvm.org/D142102



More information about the llvm-commits mailing list