[PATCH] D142379: [RISCV] Don't explicitly select X0 in select branch comparisons

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 23 09:54:29 PST 2023


craig.topper added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/double-convert.ll:141
 ; RV32I-NEXT:    call __unorddf2 at plt
 ; RV32I-NEXT:    snez a0, a0
 ; RV32I-NEXT:    addi a0, a0, -1
----------------
There used to be a branch here when I wrote the original patch. It was made branchless sometime later. Perhaps the coalescer wasn't improved and the test cases don't cover it anymore?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142379/new/

https://reviews.llvm.org/D142379



More information about the llvm-commits mailing list