[PATCH] D140271: [NFCI][llvm-exegesis] Benchmark: parallelize codegen (5x ... 8x less wallclock)

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 23 09:05:54 PST 2023


lebedev.ri added inline comments.


================
Comment at: llvm/tools/llvm-exegesis/llvm-exegesis.cpp:359
+  using ExpectedRunnableConfiguration =
+      std::optional<Expected<exegesis::BenchmarkRunner::RunnableConfiguration>>;
+  SmallVector<SmallVector<ExpectedRunnableConfiguration, MaxRepetitors>, 1>
----------------
gchatelet wrote:
> I think we can drop the `exegesis` namespace qualifier here.
Right. This kind of thing is probably happening in a few other places.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140271/new/

https://reviews.llvm.org/D140271



More information about the llvm-commits mailing list