[PATCH] D141863: [llvm][APFloat] Add NaN-in-negative-zero formats by AMD and GraphCore

[Jake Hall via Phabricator via llvm-commits]

jakeh-gc added inline comments.


================
Comment at: llvm/unittests/ADT/APFloatTest.cpp:1877
+      {&APFloat::Float8E4M3FNUZ(), true, false, {0, 0}, 1}};
+  const unsigned NumGetZeroTests = 16;
   for (unsigned i = 0; i < NumGetZeroTests; ++i) {
----------------
There are now 20 test cases, not 16.
12 wasn't a correct value for this before.

My preference is to use `std::size` here to avoid these issues in future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141863/new/

https://reviews.llvm.org/D141863