[PATCH] D142093: [InstCombine] trunc (fptoui|fptosi)

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 23 08:22:25 PST 2023


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCasts.cpp:508
+    Type *InputTy = I->getOperand(0)->getType()->getScalarType();
+    const fltSemantics &semantics = InputTy->getFltSemantics();
+    uint32_t MinBitWidth = APFloatBase::semanticsMaxExponent(semantics);
----------------
Formatting nit: variable should have a capitalized name.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142093/new/

https://reviews.llvm.org/D142093



More information about the llvm-commits mailing list