[PATCH] D142356: [MC] Use MCRI instead of MRI for MCRegisterInfo. NFC.
Sergei Barannikov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 23 07:42:23 PST 2023
barannikov88 added a comment.
In D142356#4073605 <https://reviews.llvm.org/D142356#4073605>, @foad wrote:
> In D142356#4073505 <https://reviews.llvm.org/D142356#4073505>, @barannikov88 wrote:
>
>> IMHO there is no confusion. `MachineRegisterInfo` is only used in CodeGen, while `MCRegisterInfo` is primarily used in MC layer.
>> Just note that almost all affected files are in MCTargetDesc/AsmParser/Disassembler directories.
>
> I don't feel too strongly about it, but there are a bunch of files that use both, like `lib/Target/*/*FrameLowering.cpp`.
I believe they could be refactored to use `TargetRegisterInfo` instead. This is at least true for `getDwarfRegNum`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142356/new/
https://reviews.llvm.org/D142356
More information about the llvm-commits
mailing list