[PATCH] D141891: [VP][DAGCombiner] Introduce generalized pattern match for vp sdnodes.
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 23 06:17:08 PST 2023
spatel added inline comments.
================
Comment at: llvm/include/llvm/CodeGen/ISDOpcodes.h:1348
+/// Translate this VP Opcode to its corresponding non-VP Opcode.
+std::optional<unsigned> getFunctionOpcodeForVP(unsigned Opcode,
+ bool hasFPExcept);
----------------
frasercrmck wrote:
> I'm not mad about the term "function opcode" - it doesn't sound right to me. I don't have a better suggestion right now though. I'm just commenting this in case other people feel similarly.
Just a passing comment because it took me 3 tries to translate that "mad" from the American English "angry" to the British English "crazy" and then to "happy". :)
Possible alternate:
getNonPredOpcodeForVP()
or less contracted:
getNonPredicatedOpcodeForVPOpcode()
or:
getBaseOpcodeForVPOpcode()
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141891/new/
https://reviews.llvm.org/D141891
More information about the llvm-commits
mailing list