[PATCH] D136524: [InstCombine] Handle select inst when eliminating constant memcpy

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp:324
+      if (!Worklist.contains(cast<Instruction>(SI->getTrueValue())) ||
+          !Worklist.contains(cast<Instruction>(SI->getFalseValue()))) {
+        ValuesToRevisit.insert(Inst);
----------------
Okay, I understand now why the new test case does not fold. Please switch this to the isAvailable() method added in https://github.com/llvm/llvm-project/commit/ed9806363beb1caf5265e75a64de904b60218093 and regenerate the test. I think then everything should work as expected.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136524/new/

https://reviews.llvm.org/D136524