[PATCH] D142135: [AArch64] Basic target("+crypto") handling

Mon Jan 23 03:48:01 PST 2023

dmgreen added a comment.

In D142135#4067910 <https://reviews.llvm.org/D142135#4067910>, @tmatheson wrote:

> I'm concerned that the `+crypto` situation is already confusing, and adding another different meaning for it in the context of the `target(...)` attribute exacerbates it. Is the plan for this to eventually match the behaviour of `-march=...+crypto`?

Yeah - Considering that GCC has not implemented armv8.4-a+crypto implying +sha3 and +sm4, we either have the option of matching the behavior of GCC's `target("+crypto")`, or being more consistent with clang's `-march=...`. With a number of CPU's being released which implement SHA3 but not SM4, the simpler GCC implementation might be the better way to go to be honest, and we could consider changing how `-march` works in clang to match.

If you feel strongly I can have a go at implementing it to be arch dependent. Let me know.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142135/new/

https://reviews.llvm.org/D142135