[PATCH] D141386: [LangRef] Make !range, !nonnull and !align return poison instead of IUB

Mon Jan 23 02:18:15 PST 2023

nikic added a comment.

In D141386#4069084 <https://reviews.llvm.org/D141386#4069084>, @nlopes wrote:

> In D141386#4069054 <https://reviews.llvm.org/D141386#4069054>, @nikic wrote:
>
>> In D141386#4048676 <https://reviews.llvm.org/D141386#4048676>, @nlopes wrote:
>>
>>> Three failures:
>>>
>>> - Transforms/InstCombine/loadstore-metadata.ll
>>> - Transforms/Mem2Reg/preserve-nonnull-load-metadata.ll
>>> - Transforms/SROA/preserve-nonnull.ll
>>
>> The last two should be fixed by https://github.com/llvm/llvm-project/commit/e6241cbdcbf3cc9beb49460578466e18936ef220.
>
> Thank you!
>
>> For the InstCombine test the online alive instance currently crashes (https://alive2.llvm.org/ce/z/dZko2g), so not sure what's wrong with that one.
>
> It doesn't like this: `!nonnull !6`.
> It is failing the assertion that !nonnull has no arguments. I would hope the IR verifier would catch this though.

I've added the verifier check in https://github.com/llvm/llvm-project/commit/474f20ba26400559e5d99fd4f29926253092f00b.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141386/new/

https://reviews.llvm.org/D141386