[PATCH] D142198: [AArch64][SME2] NFC: Simplify multiclasses for mova/movaz.

[Caroline via Phabricator via llvm-commits]

CarolineConcatto accepted this revision.
CarolineConcatto added a comment.
This revision is now accepted and ready to land.

Thank you Sander for the patch!
IMHO it is ok to simplify the classes, as far as all the alias are still there.
I just would add the comments we had before on top of the multiclasses.
But besides that I see no problem.



================
Comment at: llvm/lib/Target/AArch64/SMEInstrFormats.td:3308
 
 // SME2 move tile to vector, two registers
+multiclass sme2_mova_tile_to_vec_vg2_multi_inst<bit v, bits<3> opc, string mnemonic> {
----------------
I think that the comments should be on top of the multi-class, not here.


================
Comment at: llvm/lib/Target/AArch64/SMEInstrFormats.td:3400
 }
 
 multiclass sme2_mova_tile_to_vec_vg2_multi<string mnemonic>{
----------------
Maybe add: 
 SME2 move tile to vector, two register


================
Comment at: llvm/lib/Target/AArch64/SMEInstrFormats.td:3405
 }
 
 multiclass sme2p1_movaz_tile_to_vec_vg2<string mnemonic>{
----------------
Maybe add:
// SME2.1 zeroing move tile to vector, two registers


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142198/new/

https://reviews.llvm.org/D142198