[PATCH] D141830: [NFC] Use new version of SelectionDAG::getLoad in NVPTX LowerFormalArguments

Guillaume Chatelet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 23 01:13:52 PST 2023


gchatelet added a comment.

In D141830#4069631 <https://reviews.llvm.org/D141830#4069631>, @tra wrote:

> In D141830#4068313 <https://reviews.llvm.org/D141830#4068313>, @gchatelet wrote:
>
>> You can see the original RFC <https://lists.llvm.org/pipermail/llvm-dev/2019-July/133851.html> to see why this can be beneficial.
>
> Ah. Now the patch does make sense. Sorry about the push back.

No worries, **I** should have been clearer on the motivation of this patch from the very beginning.
Thx for the review!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141830/new/

https://reviews.llvm.org/D141830



More information about the llvm-commits mailing list