[PATCH] D141258: [AArch64] Fix crash for expandMOVImm

Allen zhong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 15 18:48:48 PST 2023


Allen updated this revision to Diff 489413.
Allen added a comment.

Apply the comment


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141258/new/

https://reviews.llvm.org/D141258

Files:
  llvm/lib/Target/AArch64/AArch64ExpandImm.cpp
  llvm/test/CodeGen/AArch64/const-isel.ll


Index: llvm/test/CodeGen/AArch64/const-isel.ll
===================================================================
--- /dev/null
+++ llvm/test/CodeGen/AArch64/const-isel.ll
@@ -0,0 +1,16 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mtriple=aarch64-none-linux-gnu -fast-isel -verify-machineinstrs < %s | FileCheck %s --check-prefix=FISEL
+
+define i53 @PR59892 () {
+; FISEL-LABEL: PR59892:
+; FISEL:       // %bb.0:
+; FISEL-NEXT:    mov x8, #47668
+; FISEL-NEXT:    movk x8, #4645, lsl #16
+; FISEL-NEXT:    movk x8, #58741, lsl #32
+; FISEL-NEXT:    movk x8, #1, lsl #48
+; FISEL-NEXT:    orr x9, x8, #0x2
+; FISEL-NEXT:    mul x0, x9, x8
+; FISEL-NEXT:    ret
+  %a = mul nsw i53 533765955107380, 533765955107382
+  ret i53 %a
+}
Index: llvm/lib/Target/AArch64/AArch64ExpandImm.cpp
===================================================================
--- llvm/lib/Target/AArch64/AArch64ExpandImm.cpp
+++ llvm/lib/Target/AArch64/AArch64ExpandImm.cpp
@@ -303,6 +303,8 @@
 void AArch64_IMM::expandMOVImm(uint64_t Imm, unsigned BitSize,
                                SmallVectorImpl<ImmInsnModel> &Insn) {
   const unsigned Mask = 0xFFFF;
+  // Adapt to the width of a register.
+  BitSize = BitSize <= 32 ? 32 : 64;
 
   // Scan the immediate and count the number of 16-bit chunks which are either
   // all ones or all zeros.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D141258.489413.patch
Type: text/x-patch
Size: 1378 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230116/cba47bed/attachment-0001.bin>


More information about the llvm-commits mailing list