[PATCH] D137800: [llvm-driver] Reinvoke clang as described by llvm driver extra args

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 15 17:03:06 PST 2023


phosek added inline comments.


================
Comment at: clang/include/clang/Driver/Driver.h:295
+  /// "clang" as it's first argument.
+  const char *LLVMDriverPrependArg;
+
----------------
I'd call it just `PrependArg` since it might have uses outside of LLVM driver.


================
Comment at: clang/tools/driver/driver.cpp:488
+  std::string Path = GetExecutablePath(
+      ToolContext.Path, CanonicalPrefixes && !ToolContext.IsDriver);
 
----------------
Is there a reason why we couldn't support `-canonical-prefixes` for the driver case?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137800/new/

https://reviews.llvm.org/D137800



More information about the llvm-commits mailing list