[llvm] db6961d - [FuncitonComparator] Clamp StringRef compare output to [-1,1]

[Benjamin Kramer via llvm-commits]

Author: Benjamin Kramer
Date: 2023-01-16T01:44:55+01:00
New Revision: db6961db7a0d44da3dd7d0a604f43fc7db8b21b5

URL: https://github.com/llvm/llvm-project/commit/db6961db7a0d44da3dd7d0a604f43fc7db8b21b5
DIFF: https://github.com/llvm/llvm-project/commit/db6961db7a0d44da3dd7d0a604f43fc7db8b21b5.diff

LOG: [FuncitonComparator] Clamp StringRef compare output to [-1,1]

The comparison can have different values (but same sign) on big endian
platforms, avoid that to make the unit test green there.

Added: 
    

Modified: 
    llvm/lib/Transforms/Utils/FunctionComparator.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/Utils/FunctionComparator.cpp b/llvm/lib/Transforms/Utils/FunctionComparator.cpp
index 6e93de540cf1..3fa61ec68cd3 100644
--- a/llvm/lib/Transforms/Utils/FunctionComparator.cpp
+++ b/llvm/lib/Transforms/Utils/FunctionComparator.cpp
@@ -110,7 +110,7 @@ int FunctionComparator::cmpMem(StringRef L, StringRef R) const {
 
   // Compare strings lexicographically only when it is necessary: only when
   // strings are equal in size.
-  return L.compare(R);
+  return std::clamp(L.compare(R), -1, 1);
 }
 
 int FunctionComparator::cmpAttrs(const AttributeList L,