[PATCH] D140841: [DWARFLinkerNext] Add StringPool class.

[Alexey Lapshin via Phabricator via llvm-commits]

avl added a comment.

There were implemented space optimizations for D132455 <https://reviews.llvm.org/D132455>. With these optimizations performance comparison looks like this:

Ubuntu
Processor Name: Intel(R) Core(TM) i9-9900
Processor Speed: 3.10GHz
Number of Processors: 1
Total Number of Cores: 8
Memory: 64 GB

  -------------------------------------------------------------------------
                       |      lldb-pool      |  ConcurrentHashTable pool  |
  -------------------------------------------------------------------------
    threads 1          | time:     22.9sec   | time:       17.8sec        |
                       | mem:       5.0G     |  mem:        5.56G         |
  -------------------------------------------------------------------------
    threads  8         | time:      5.4sec   | time:        4.5sec        |
                       | mem:       5.0G     |  mem:        5.57G         |
  -------------------------------------------------------------------------
    threads 16         | time:      4.2sec   | time:        3.3sec        |
                       | mem:       5.0G     |  mem:        5.56G         |
  -------------------------------------------------------------------------
   init-size 100000000 |                     | time:       11.3sec        |
    threads  1         |                     |  mem:        5.2G          |
  -------------------------------------------------------------------------
   init-size 100000000 |                     | time:        2.8sec        |
    threads  8         |                     |  mem:        5.2G          |
  -------------------------------------------------------------------------
   init-size 100000000 |                     | time:        2.5sec        |
    threads 16         |                     |  mem:        5.2G          |
  -------------------------------------------------------------------------

Darwin
Processor Name: 12-Core Intel Xeon E5
Processor Speed: 2.7 GHz
Number of Processors: 1
Total Number of Cores: 12
Memory: 64 GB

  -------------------------------------------------------------------------
                       |      lldb-pool      |  ConcurrentHashTable pool  |
  -------------------------------------------------------------------------
    threads 1          | time:     33.4sec   | time:       26.2sec        |
                       | mem:       5.3G     |  mem:        5.7G          |
  -------------------------------------------------------------------------
    threads  8         | time:     11.2sec   | time:        4.9sec        |
                       | mem:       5.4G     |  mem:        5.7G          |
  -------------------------------------------------------------------------
    threads 24         | time:     29.8sec   | time:        2.3sec        |
                       | mem:       5.5G     |  mem:        5.7G          |
  -------------------------------------------------------------------------
   init-size 100000000 |                     | time:       18.8sec        |
    threads  1         |                     |  mem:        5.3G          |
  -------------------------------------------------------------------------
   init-size 100000000 |                     | time:        3.3sec        |
    threads  8         |                     |  mem:        5.3G          |
  -------------------------------------------------------------------------
   init-size 100000000 |                     | time:        1.8sec        |
    threads 24         |                     |  mem:        5.3G          |
  -------------------------------------------------------------------------


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140841/new/

https://reviews.llvm.org/D140841