[PATCH] D141722: Attributes: Check declarations for dereferenceable bytes

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

Pretty canonical. We should use maximum though. And can you do this for all deref getters please.



================
Comment at: llvm/include/llvm/IR/InstrTypes.h:1813
+
+    return Bytes;
   }
----------------
Yes, maximum please.


================
Comment at: llvm/include/llvm/IR/InstrTypes.h:1832
     return Attrs.getParamDereferenceableOrNullBytes(i);
   }
 
----------------
Can you fix all 4 deref getters while you are here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141722/new/

https://reviews.llvm.org/D141722