[PATCH] D141777: [X86] Reenable store merging post-legalization

[Sergei Barannikov via Phabricator via llvm-commits]

barannikov88 added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:606
+  enum class StoreSource {
+    Unknown,
+    Constant,
----------------
lebedev.ri wrote:
> barannikov88 wrote:
> > Appears unused with std::optional.
> > 
> I do not follow. Both the struct and the element are both clearly still used.
Yes, my bad. Although mergeStoresAfterLegalization will never receive Unknown.
I'd suggest to stick to either Unknown or std::optional, but not both. Either is fine to me.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141777/new/

https://reviews.llvm.org/D141777