[PATCH] D141785: [Clang][LoongArch] Implement patchable function entry

Lu Weining via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 15 05:40:51 PST 2023


SixWeining added a comment.

Does anyone know why `patchable-function-entry` is not documented in https://llvm.org/docs/LangRef.html#function-attributes?



================
Comment at: llvm/lib/Target/LoongArch/LoongArchMCInstLower.cpp:150
+              .getAsInteger(10, Num))
+        return false;
+      AP.emitNops(Num);
----------------
Seems should return `true`? Consider when verifier is disabled.

How about handling `PATCHABLE_FUNCTION_ENTER` in `LoongArchAsmPrinter.cpp` like D140727?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141785/new/

https://reviews.llvm.org/D141785



More information about the llvm-commits mailing list