[PATCH] D141777: [X86] Reenable store merging post-legalization

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 15 05:16:24 PST 2023


lebedev.ri added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:19397-19398
+
+  if (LegalTypes &&
+      !TLI.mergeStoresAfterLegalization(St->getMemoryVT(), StoreSrc))
     return false;
----------------
pengfei wrote:
> If I read the patch correctly, this is the real point we care about. Should it be better to just introduce another TLI function to do such work?
I don't see why? We are simply enriching it with more knowledge to give a more precise answer.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141777/new/

https://reviews.llvm.org/D141777



More information about the llvm-commits mailing list