[PATCH] D141782: [X86] Don't fold select for vXi1 on X86 target.

Phoebe Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 15 04:13:05 PST 2023


pengfei added inline comments.


================
Comment at: llvm/test/CodeGen/X86/fold-select.ll:4
 
 define <8 x float> @select_and_v8i1(<8 x i1> %a, <8 x i1> %b, <8 x i1> %c, <8 x float> %d) {
 ; CHECK-LABEL: select_and_v8i1:
----------------
I think passing vXi1 from arguments is not a common scenario. vXi1 will be promoted vXi16 during lowering arguments. You should add new test cases that generating vXi1 in the IR, e.g.:
```
%a = icmp eq <8 x i16> %0, %1
...
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141782/new/

https://reviews.llvm.org/D141782



More information about the llvm-commits mailing list